From c870b95be997d1c4c3688bd1331a351054c48e40 Mon Sep 17 00:00:00 2001 From: gamer147 Date: Fri, 12 Jun 2026 23:22:25 -0400 Subject: [PATCH] feat(sleeve): /sleeve/favorite accept-only (persistence deferred) --- .../Controllers/SleeveController.cs | 10 +++++ .../Requests/Sleeve/SleeveFavoriteRequest.cs | 18 ++++++++ .../SleeveControllerFavoriteTests.cs | 44 +++++++++++++++++++ 3 files changed, 72 insertions(+) create mode 100644 SVSim.EmulatedEntrypoint/Models/Dtos/Requests/Sleeve/SleeveFavoriteRequest.cs create mode 100644 SVSim.UnitTests/Controllers/SleeveControllerFavoriteTests.cs diff --git a/SVSim.EmulatedEntrypoint/Controllers/SleeveController.cs b/SVSim.EmulatedEntrypoint/Controllers/SleeveController.cs index 861ae135..62e54dcf 100644 --- a/SVSim.EmulatedEntrypoint/Controllers/SleeveController.cs +++ b/SVSim.EmulatedEntrypoint/Controllers/SleeveController.cs @@ -169,6 +169,16 @@ public class SleeveController : SVSimController .ToList(); } + [HttpPost("favorite")] + public ActionResult Favorite([FromBody] SleeveFavoriteRequest _) + { + if (!TryGetViewerId(out long __)) return Unauthorized(); + // Accept-and-ack. Persisting per-viewer cosmetic favorites is deferred until + // a viewer-favorites schema lands (would also serve /emblem/favorite + /degree/favorite + // via the shared Wizard/FavoriteTask.cs Kind enum). Same pattern as ConfigController. + return new EmptyResponse(); + } + /// /// A product is "purchased" once the viewer owns at least one of its sleeve-typed reward /// grants. Emblem/other grants aren't load-bearing for this check — a viewer who somehow diff --git a/SVSim.EmulatedEntrypoint/Models/Dtos/Requests/Sleeve/SleeveFavoriteRequest.cs b/SVSim.EmulatedEntrypoint/Models/Dtos/Requests/Sleeve/SleeveFavoriteRequest.cs new file mode 100644 index 00000000..7b18f69a --- /dev/null +++ b/SVSim.EmulatedEntrypoint/Models/Dtos/Requests/Sleeve/SleeveFavoriteRequest.cs @@ -0,0 +1,18 @@ +using MessagePack; +using System.Text.Json.Serialization; +using SVSim.EmulatedEntrypoint.Models.Dtos.Requests; + +namespace SVSim.EmulatedEntrypoint.Models.Dtos.Requests.Sleeve; + +[MessagePackObject] +public class SleeveFavoriteRequest : BaseRequest +{ + // Spec note: ids are STRINGS on the wire, not ints. Don't change to long[]. + [JsonPropertyName("favorite_add")] + [Key("favorite_add")] + public List FavoriteAdd { get; set; } = new(); + + [JsonPropertyName("favorite_remove")] + [Key("favorite_remove")] + public List FavoriteRemove { get; set; } = new(); +} diff --git a/SVSim.UnitTests/Controllers/SleeveControllerFavoriteTests.cs b/SVSim.UnitTests/Controllers/SleeveControllerFavoriteTests.cs new file mode 100644 index 00000000..f897b83c --- /dev/null +++ b/SVSim.UnitTests/Controllers/SleeveControllerFavoriteTests.cs @@ -0,0 +1,44 @@ +using System.Net; +using System.Text; +using NUnit.Framework; +using SVSim.UnitTests.Infrastructure; + +namespace SVSim.UnitTests.Controllers; + +public class SleeveControllerFavoriteTests +{ + [Test] + public async Task Favorite_accepts_add_and_remove_lists() + { + using var factory = new SVSimTestFactory(); + long viewerId = await factory.SeedViewerAsync(tutorialState: 0); + using var client = factory.CreateAuthenticatedClient(viewerId); + + // Stringified ids per spec. + var requestJson = """ + { + "favorite_add":["100","101"], + "favorite_remove":["200"], + "viewer_id":"0","steam_id":0,"steam_session_ticket":"" + } + """; + var response = await client.PostAsync("/sleeve/favorite", + new StringContent(requestJson, Encoding.UTF8, "application/json")); + + Assert.That(response.StatusCode, Is.EqualTo(HttpStatusCode.OK)); + } + + [Test] + public async Task Favorite_accepts_empty_lists() + { + using var factory = new SVSimTestFactory(); + long viewerId = await factory.SeedViewerAsync(tutorialState: 0); + using var client = factory.CreateAuthenticatedClient(viewerId); + + var requestJson = """{"favorite_add":[],"favorite_remove":[],"viewer_id":"0","steam_id":0,"steam_session_ticket":""}"""; + var response = await client.PostAsync("/sleeve/favorite", + new StringContent(requestJson, Encoding.UTF8, "application/json")); + + Assert.That(response.StatusCode, Is.EqualTo(HttpStatusCode.OK)); + } +}