SVSim/SVSimServer
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(rank-battle): inherit BaseRequest so auth fields survive translation roundtrip

Browse Source 
The translation middleware decrypts + msgpack-decodes the request body
into the action's first-parameter type, then re-serializes that DTO to
JSON for the auth handler to read. Phase 3's DoMatchingRequestDto and
RankBattleFinishRequestDto didn't inherit BaseRequest, so viewer_id /
steam_id / steam_session_ticket were dropped during the msgpack → DTO
→ JSON pivot — the auth handler then saw a body with no auth fields
and 401'd every request.

Fixed by making both DTOs extend BaseRequest, mirroring the Phase 2 TK2
DoMatchingRequest pattern.

Also added [FromBody] BaseRequest parameters to the previously body-less
actions (AiStart × 2, ForceFinish, AddClientLog, GetLatestMasterPoint).
The translation middleware explicitly requires at least one parameter
to bind the decrypted msgpack body (see L130-136 of the middleware);
without it the request would throw InvalidOperationException at runtime.

Tests updated to post viewer_id / steam_id / steam_session_ticket
placeholder values in the request body, matching the existing TK2 test
pattern.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
gamer147
2026-06-02 09:29:48 -04:00
parent 8723cff998
commit bf783639c1
4 changed files with 74 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
SVSim.EmulatedEntrypoint/Models/Dtos/RankBattle/DoMatchingRequestDto.cs
View File

@@ -1,10 +1,17 @@
using System.Text.Json.Serialization;
using MessagePack;
using SVSim.EmulatedEntrypoint.Models.Dtos.Requests;
namespace SVSim.EmulatedEntrypoint.Models.Dtos.RankBattle;
[MessagePackObject(keyAsPropertyName: true)]
public sealed class DoMatchingRequestDto
/// <summary>
/// Standard DoMatchingParam shape for rank battle (rotation/unlimited). Inherits viewer_id /
/// steam_id / steam_session_ticket from <see cref="BaseRequest"/> so the auth fields survive
/// the translation-middleware msgpack → DTO → JSON round-trip (otherwise the
/// SteamSessionAuthenticationHandler sees a body without auth fields and 401s).
/// </summary>
[MessagePackObject]
public sealed class DoMatchingRequestDto : BaseRequest
{
[JsonPropertyName("deck_no")]
[Key("deck_no")]
@@ -20,7 +27,7 @@ public sealed class DoMatchingRequestDto
[JsonPropertyName("log")]
[Key("log")]
public string? Log { get; set; }
public int Log { get; set; }
[JsonPropertyName("use_stage_select")]
[Key("use_stage_select")]
@@ -28,7 +35,7 @@ public sealed class DoMatchingRequestDto
[JsonPropertyName("excluded_field_id_list")]
[Key("excluded_field_id_list")]
public int[]? ExcludedFieldIdList { get; set; }
public List<long> ExcludedFieldIdList { get; set; } = new();
[JsonPropertyName("is_default_skin")]
[Key("is_default_skin")]

8
SVSim.EmulatedEntrypoint/Models/Dtos/RankBattle/RankBattleFinishRequestDto.cs
View File

@@ -1,5 +1,6 @@
using System.Text.Json.Serialization;
using MessagePack;
using SVSim.EmulatedEntrypoint.Models.Dtos.Requests;
namespace SVSim.EmulatedEntrypoint.Models.Dtos.RankBattle;
@@ -7,9 +8,12 @@ namespace SVSim.EmulatedEntrypoint.Models.Dtos.RankBattle;
/// Standard BattleFinishParam shape — see docs/api-spec/common/types.ts.md and
/// docs/api-spec/endpoints/post-login/rank-battle/finish.md. Future: promote to
/// a shared common DTO when a second finish endpoint reuses this.
///
/// Inherits viewer_id / steam_id / steam_session_ticket from <see cref="BaseRequest"/>
/// so the auth fields survive the translation-middleware round-trip.
/// </summary>
[MessagePackObject(keyAsPropertyName: true)]
public sealed class RankBattleFinishRequestDto
[MessagePackObject]
public sealed class RankBattleFinishRequestDto : BaseRequest
{
[JsonPropertyName("battle_result")]
[Key("battle_result")]