diff --git a/SVSim.EmulatedEntrypoint/Controllers/AccountController.cs b/SVSim.EmulatedEntrypoint/Controllers/AccountController.cs
index fd50d8a..bc9be0c 100644
--- a/SVSim.EmulatedEntrypoint/Controllers/AccountController.cs
+++ b/SVSim.EmulatedEntrypoint/Controllers/AccountController.cs
@@ -10,6 +10,14 @@ namespace SVSim.EmulatedEntrypoint.Controllers;
///
public class AccountController : SVSimController
{
+ ///
+ /// Conservative server-side cap on viewer display names. The client's UserNameInput
+ /// enforces its own limit at the keyboard; this is the backstop against direct API
+ /// abuse (10-MB names ballooning every subsequent /load/index, etc.). Names are
+ /// typically <=20 chars in prod traffic.
+ ///
+ private const int MaxDisplayNameLength = 24;
+
private readonly SVSimDbContext _db;
public AccountController(SVSimDbContext db)
@@ -22,6 +30,14 @@ public class AccountController : SVSimController
{
if (!TryGetViewerId(out long viewerId)) return Unauthorized();
+ // Defensive null check: the DTO defaults to string.Empty but a JSON body with
+ // an explicit `"name": null` deserialises through msgpack→JSON→STJ to null, and
+ // assigning null to viewer.DisplayName (non-nullable in the entity) would NRE.
+ if (string.IsNullOrWhiteSpace(request.Name))
+ return BadRequest(new { error = "name_empty" });
+ if (request.Name.Length > MaxDisplayNameLength)
+ return BadRequest(new { error = "name_too_long" });
+
var viewer = await _db.Viewers.FirstAsync(v => v.Id == viewerId);
viewer.DisplayName = request.Name;
await _db.SaveChangesAsync();
diff --git a/SVSim.UnitTests/Controllers/AccountControllerTests.cs b/SVSim.UnitTests/Controllers/AccountControllerTests.cs
index 6473a06..2eed863 100644
--- a/SVSim.UnitTests/Controllers/AccountControllerTests.cs
+++ b/SVSim.UnitTests/Controllers/AccountControllerTests.cs
@@ -31,4 +31,79 @@ public class AccountControllerTests
var viewer = await db.Viewers.FirstAsync(v => v.Id == viewerId);
Assert.That(viewer.DisplayName, Is.EqualTo("littlefootse"));
}
+
+ [TestCase("")]
+ [TestCase(" ")]
+ [TestCase("\t\n")]
+ public async Task UpdateName_rejects_empty_or_whitespace(string name)
+ {
+ using var factory = new SVSimTestFactory();
+ long viewerId = await factory.SeedViewerAsync(tutorialState: 0);
+ using var client = factory.CreateAuthenticatedClient(viewerId);
+
+ var requestJson = $$"""{"name":{{JsonSerializer.Serialize(name)}},"viewer_id":"0","steam_id":0,"steam_session_ticket":""}""";
+ var response = await client.PostAsync("/account/update_name",
+ new StringContent(requestJson, Encoding.UTF8, "application/json"));
+
+ Assert.That(response.StatusCode, Is.EqualTo(HttpStatusCode.BadRequest));
+
+ // Display name remains the seeded default ("Test Viewer").
+ using var scope = factory.Services.CreateScope();
+ var db = scope.ServiceProvider.GetRequiredService();
+ var viewer = await db.Viewers.FirstAsync(v => v.Id == viewerId);
+ Assert.That(viewer.DisplayName, Is.EqualTo("Test Viewer"));
+ }
+
+ [Test]
+ public async Task UpdateName_rejects_explicit_null()
+ {
+ using var factory = new SVSimTestFactory();
+ long viewerId = await factory.SeedViewerAsync(tutorialState: 0);
+ using var client = factory.CreateAuthenticatedClient(viewerId);
+
+ // Explicit JSON null — used to NRE when the controller assigned request.Name
+ // (default string.Empty) straight to viewer.DisplayName without a null check.
+ var requestJson = """{"name":null,"viewer_id":"0","steam_id":0,"steam_session_ticket":""}""";
+ var response = await client.PostAsync("/account/update_name",
+ new StringContent(requestJson, Encoding.UTF8, "application/json"));
+
+ Assert.That(response.StatusCode, Is.EqualTo(HttpStatusCode.BadRequest));
+ }
+
+ [Test]
+ public async Task UpdateName_rejects_too_long_name()
+ {
+ using var factory = new SVSimTestFactory();
+ long viewerId = await factory.SeedViewerAsync(tutorialState: 0);
+ using var client = factory.CreateAuthenticatedClient(viewerId);
+
+ // 25 chars > the 24-char server cap.
+ var name = new string('a', 25);
+ var requestJson = $$"""{"name":"{{name}}","viewer_id":"0","steam_id":0,"steam_session_ticket":""}""";
+ var response = await client.PostAsync("/account/update_name",
+ new StringContent(requestJson, Encoding.UTF8, "application/json"));
+
+ Assert.That(response.StatusCode, Is.EqualTo(HttpStatusCode.BadRequest));
+ }
+
+ [Test]
+ public async Task UpdateName_accepts_name_at_cap_boundary()
+ {
+ using var factory = new SVSimTestFactory();
+ long viewerId = await factory.SeedViewerAsync(tutorialState: 0);
+ using var client = factory.CreateAuthenticatedClient(viewerId);
+
+ // Exactly 24 chars — boundary case.
+ var name = new string('a', 24);
+ var requestJson = $$"""{"name":"{{name}}","viewer_id":"0","steam_id":0,"steam_session_ticket":""}""";
+ var response = await client.PostAsync("/account/update_name",
+ new StringContent(requestJson, Encoding.UTF8, "application/json"));
+
+ Assert.That(response.StatusCode, Is.EqualTo(HttpStatusCode.OK));
+
+ using var scope = factory.Services.CreateScope();
+ var db = scope.ServiceProvider.GetRequiredService();
+ var viewer = await db.Viewers.FirstAsync(v => v.Id == viewerId);
+ Assert.That(viewer.DisplayName, Is.EqualTo(name));
+ }
}