feat(emblem): /emblem/update_emblem sets viewer.SelectedEmblem (ownership-validated)

This commit is contained in:
gamer147
2026-06-13 08:16:19 -04:00
parent bc110e2274
commit 911374106f
3 changed files with 91 additions and 0 deletions

View File

@@ -47,4 +47,24 @@ public class EmblemController : SVSimController
// via the shared Wizard/FavoriteTask.cs Kind enum).
return new EmptyResponse();
}
[HttpPost("update_emblem")]
public async Task<ActionResult<EmptyResponse>> Update(EmblemUpdateRequest request, CancellationToken ct)
{
if (!TryGetViewerId(out long viewerId)) return Unauthorized();
var viewer = await _db.Viewers
.Include(v => v.Emblems)
.FirstOrDefaultAsync(v => v.Id == viewerId, ct);
if (viewer is null) return Unauthorized();
// EmblemEntry.Id is int; cast the wire long once at the boundary.
var owned = viewer.Emblems.FirstOrDefault(e => e.Id == (int)request.EmblemId);
if (owned is null)
return BadRequest(new { error = "emblem_not_owned" });
viewer.Info.SelectedEmblem = owned;
await _db.SaveChangesAsync(ct);
return new EmptyResponse();
}
}

View File

@@ -0,0 +1,13 @@
using MessagePack;
using System.Text.Json.Serialization;
namespace SVSim.EmulatedEntrypoint.Models.Dtos.Requests.Emblem;
[MessagePackObject]
public class EmblemUpdateRequest : BaseRequest
{
// Spec note: emblem_id is a long on the wire (UserInfo.SelectedEmblemId is also long).
[JsonPropertyName("emblem_id")]
[Key("emblem_id")]
public long EmblemId { get; set; }
}

View File

@@ -0,0 +1,58 @@
using System.Net;
using System.Text;
using NUnit.Framework;
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.DependencyInjection;
using SVSim.Database;
using SVSim.Database.Models;
using SVSim.UnitTests.Infrastructure;
namespace SVSim.UnitTests.Controllers;
public class EmblemControllerUpdateTests
{
[Test]
public async Task Update_persists_selected_emblem_when_owned()
{
using var factory = new SVSimTestFactory();
long viewerId = await factory.SeedViewerAsync(tutorialState: 0);
using (var scope = factory.Services.CreateScope())
{
var db = scope.ServiceProvider.GetRequiredService<SVSimDbContext>();
var viewer = await db.Viewers.Include(v => v.Emblems).FirstAsync(v => v.Id == viewerId);
var e500 = await db.Set<EmblemEntry>().FirstOrDefaultAsync(e => e.Id == 500)
?? db.Set<EmblemEntry>().Add(new EmblemEntry { Id = 500 }).Entity;
viewer.Emblems.Add(e500);
await db.SaveChangesAsync();
}
using var client = factory.CreateAuthenticatedClient(viewerId);
var requestJson = """{"emblem_id":500,"viewer_id":"0","steam_id":0,"steam_session_ticket":""}""";
var response = await client.PostAsync("/emblem/update_emblem",
new StringContent(requestJson, Encoding.UTF8, "application/json"));
Assert.That(response.StatusCode, Is.EqualTo(HttpStatusCode.OK));
using var scope2 = factory.Services.CreateScope();
var db2 = scope2.ServiceProvider.GetRequiredService<SVSimDbContext>();
var viewer2 = await db2.Viewers
.Include(v => v.Info.SelectedEmblem)
.FirstAsync(v => v.Id == viewerId);
Assert.That(viewer2.Info.SelectedEmblem.Id, Is.EqualTo(500));
}
[Test]
public async Task Update_rejects_unowned_emblem()
{
using var factory = new SVSimTestFactory();
long viewerId = await factory.SeedViewerAsync(tutorialState: 0);
using var client = factory.CreateAuthenticatedClient(viewerId);
var requestJson = """{"emblem_id":99999,"viewer_id":"0","steam_id":0,"steam_session_ticket":""}""";
var response = await client.PostAsync("/emblem/update_emblem",
new StringContent(requestJson, Encoding.UTF8, "application/json"));
Assert.That(response.StatusCode, Is.EqualTo(HttpStatusCode.BadRequest));
}
}