From 8085119439b08547a645e3b8c3a93a3bb4a4cb84 Mon Sep 17 00:00:00 2001 From: gamer147 Date: Wed, 3 Jun 2026 20:06:25 -0400 Subject: [PATCH] refactor(battle-node): tidy residue after scripted dispatch-arm removal Remove the now-unused SVSim.BattleNode.Lifecycle using from FrameDispatchContext (it was only needed for ScriptedLifecycle inside the deleted IsScriptedBot helper) and reword the SenderPhase doc comment so it no longer references the removed dispatch-test scripted-bot stub. Co-Authored-By: Claude Opus 4.8 --- SVSim.BattleNode/Sessions/Dispatch/FrameDispatchContext.cs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/SVSim.BattleNode/Sessions/Dispatch/FrameDispatchContext.cs b/SVSim.BattleNode/Sessions/Dispatch/FrameDispatchContext.cs index 93d23ba..83dd0ef 100644 --- a/SVSim.BattleNode/Sessions/Dispatch/FrameDispatchContext.cs +++ b/SVSim.BattleNode/Sessions/Dispatch/FrameDispatchContext.cs @@ -1,4 +1,3 @@ -using SVSim.BattleNode.Lifecycle; using SVSim.BattleNode.Protocol; using SVSim.BattleNode.Sessions.Participants; // IHasHandshakePhase @@ -19,8 +18,8 @@ internal sealed class FrameDispatchContext internal required string BattleId { get; init; } internal required BattleSessionState State { get; init; } - /// Sender's per-side handshake phase (null for a non-IHasHandshakePhase participant, - /// e.g. NoOpBot or the dispatch-test scripted-bot stub). Setting it advances the sender. + /// The dispatching participant's handshake phase (null for a non-IHasHandshakePhase + /// participant, e.g. NoOpBot). Setting it advances the sender. internal BattleSessionPhase? SenderPhase { get => (From as IHasHandshakePhase)?.Phase;