SVSim/SVSimServer
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

config(default-grants): zero out shipped Crystals/Rupees/Ether

Browse Source 
Tutorial gifts now cover the starter pack + starter deck flow (crystals
+ ether + tickets granted via ViewerPresents on signup), so the 50k/50k/50k
default deposit was double-dipping. Zero the ShippedDefaults so a fresh
viewer's currency reflects exactly what they've earned.

Also update the two tests that asserted the old 50k baseline.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
gamer147
2026-07-04 14:54:43 -04:00
parent 05d143d2e8
commit 6b0b467f31
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
SVSim.Database/Models/Config/DefaultGrantsConfig.cs
View File

@@ -4,9 +4,9 @@ namespace SVSim.Database.Models.Config;
[ConfigSection("DefaultGrants")] [ConfigSection("DefaultGrants")]
public class DefaultGrantsConfig public class DefaultGrantsConfig
{ {
public ulong Crystals { get; set; } = 50000; public ulong Crystals { get; set; } = 0;
public ulong Rupees { get; set; } = 50000; public ulong Rupees { get; set; } = 0;
public ulong Ether { get; set; } = 50000; public ulong Ether { get; set; } = 0;
public static DefaultGrantsConfig ShippedDefaults() => new(); public static DefaultGrantsConfig ShippedDefaults() => new();
} }

2
SVSim.UnitTests/Controllers/AchievementControllerTests.cs
View File

@@ -100,7 +100,7 @@ public class AchievementControllerTests
var grant = rewardList[0]; var grant = rewardList[0];
Assert.That(grant.GetProperty("reward_type").GetInt32(), Is.EqualTo(9)); Assert.That(grant.GetProperty("reward_type").GetInt32(), Is.EqualTo(9));
// For currency grants, reward_num is the POST-STATE TOTAL (per project convention, // For currency grants, reward_num is the POST-STATE TOTAL (per project convention,
// matches /pack/open behavior). Default-seeded viewer has 50000 rupees → 50100 after grant. // matches /pack/open behavior). Default-seeded viewer starts at 0 rupees → 100 after grant.
Assert.That(grant.GetProperty("reward_num").GetInt32(), Is.GreaterThanOrEqualTo(100), Assert.That(grant.GetProperty("reward_num").GetInt32(), Is.GreaterThanOrEqualTo(100),
"reward_num is post-state total for currencies, must be at least the granted amount"); "reward_num is post-state total for currencies, must be at least the granted amount");
} }

6
SVSim.UnitTests/Models/GameConfigurationJsonbTests.cs
View File

@@ -55,9 +55,9 @@ public class GameConfigurationJsonbTests
Assert.That(slot8!.Silver, Is.EqualTo(0.7692).Within(1e-9)); Assert.That(slot8!.Silver, Is.EqualTo(0.7692).Within(1e-9));
var grants = JsonSerializer.Deserialize<DefaultGrantsConfig>(byName["DefaultGrants"].ValueJson)!; var grants = JsonSerializer.Deserialize<DefaultGrantsConfig>(byName["DefaultGrants"].ValueJson)!;
Assert.That(grants.Crystals, Is.EqualTo(50000UL)); Assert.That(grants.Crystals, Is.EqualTo(0UL));
Assert.That(grants.Rupees, Is.EqualTo(50000UL)); Assert.That(grants.Rupees, Is.EqualTo(0UL));
Assert.That(grants.Ether, Is.EqualTo(50000UL)); Assert.That(grants.Ether, Is.EqualTo(0UL));
var player = JsonSerializer.Deserialize<PlayerConfig>(byName["Player"].ValueJson)!; var player = JsonSerializer.Deserialize<PlayerConfig>(byName["Player"].ValueJson)!;
Assert.That(player.MaxFriends, Is.EqualTo(20)); Assert.That(player.MaxFriends, Is.EqualTo(20));