refactor(matching): IMatchingResolver shared by every do_matching family

SoloDefaultsToScripted was only consulted by ArenaTwoPickBattleController;
RankBattleController did its own inline pair-up + state-code mapping and
ignored the flag entirely. Result: turning on the flag globally only
short-circuited TK2 polls, while rank-battle polls still parked for the
PvpFirstThenAiFallback threshold (15s) before resolving — surfaced today
when the user set the flag and saw rank-battle still queue, then bot-
battle via the client-side AI (not the server-side Scripted lifecycle we
need to test WS traffic against).

New IMatchingResolver owns the cross-cutting decisions:
- honor scriptedOptIn (per-request) OR options.SoloDefaultsToScripted
  (process-wide) — bypass pair-up, register Scripted, return 3004
- otherwise call IMatchingPairUpService.TryPairAsync and translate the
  PairUpResult to the 3002/3004/3007/3011 vocabulary

Family controllers shed the duplicated logic:
- ArenaTwoPickBattleController: ~50 LOC → ~25; preserves ?scripted=1
  query opt-in (parsed permissively for "1"/"true") and the
  ArenaTwoPickException catch
- RankBattleController: ~30 LOC → ~12; preserves the 3001 mapping for
  InvalidOperationException (no deck for format) and card_master_id
  emission

DoMatchingContractTests is the durable enforcement: parametrized over
TK2 + rotation + unlimited rank, asserts SoloDefaultsToScripted=true
makes every family's first poll skip 3002 and return SUCCEEDED with a
battle_id + node_server_url. Adding a fourth family that forgets to
route through IMatchingResolver fails this test — that's the point.

MatchingResolverTests covers the six resolver paths in isolation with
mocks; per-test Harness locals (not fixture-level fields) because the
assembly is [Parallelizable(ParallelScope.All)] and shared mocks race.

957 tests passing (was 948; +9: 6 resolver + 3 contract parametrizations).
No regressions in the existing TK2 / rank-battle controller suites.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

SVSim.EmulatedEntrypoint/Controllers/RankBattleController.cs

@@ -23,23 +23,20 @@ namespace SVSim.EmulatedEntrypoint.Controllers;
 [Authorize(AuthenticationSchemes = SteamAuthenticationConstants.SchemeName)]
 public sealed class RankBattleController : ControllerBase
 {
-    private readonly IMatchingPairUpService _pairUp;
-    private readonly IMatchingBridge _bridge;
+    private readonly IMatchingResolver _resolver;
     private readonly IBattleSessionStore _sessionStore;
     private readonly IMatchContextBuilder _ctxBuilder;
     private readonly IBotRoster _botRoster;
     private readonly ILogger<RankBattleController> _log;
 
     public RankBattleController(
-        IMatchingPairUpService pairUp,
-        IMatchingBridge bridge,
+        IMatchingResolver resolver,
         IBattleSessionStore sessionStore,
         IMatchContextBuilder ctxBuilder,
         IBotRoster botRoster,
         ILogger<RankBattleController> log)
     {
-        _pairUp = pairUp;
-        _bridge = bridge;
+        _resolver = resolver;
         _sessionStore = sessionStore;
         _ctxBuilder = ctxBuilder;
         _botRoster = botRoster;
@@ -135,33 +132,16 @@ public sealed class RankBattleController : ControllerBase
             return Ok(new DoMatchingResponseDto { MatchingState = 3001, NodeServerUrl = "" });
         }
 
-        var paired = await _pairUp.TryPairAsync(mode, new BattlePlayer(vid, ctx), ct);
-
-        if (paired is null)
-        {
-            // Parked. 3002 RETRY. node_server_url must be present as empty string —
-            // client's DoMatchingBase parser calls .ToString() without a guard.
-            return Ok(new DoMatchingResponseDto
-            {
-                MatchingState = 3002,
-                NodeServerUrl = "",
-            });
-        }
-
-        // Owner cache-pickup → 3007 (PvP) or 3011 (AI fallback).
-        // Joiner (only PvP) → 3004.
-        var state = paired switch
-        {
-            { IsAiFallback: true } => 3011,
-            { IsOwner: true } => 3007,
-            _ => 3004,
-        };
+        // Rank battle has no ?scripted=1 query opt-in (no live capture has shown such a
+        // param on the rank URLs). The process-wide BattleNodeOptions.SoloDefaultsToScripted
+        // toggle is the only scripted entry point and is honored inside the resolver.
+        var r = await _resolver.ResolveAsync(mode, new BattlePlayer(vid, ctx), scriptedOptIn: false, ct);
 
         return Ok(new DoMatchingResponseDto
         {
-            MatchingState = state,
-            BattleId = paired.Match.BattleId,
-            NodeServerUrl = paired.Match.NodeServerUrl,
+            MatchingState = r.MatchingState,
+            BattleId = r.BattleId,
+            NodeServerUrl = r.NodeServerUrl,
             // Placeholder per spec § Out of scope — per-battle card-master split is deferred.
             CardMasterId = 0,
         });