SVSim/SVSimServer
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(http): inherit BaseRequest on all TK2 + Colosseum request DTOs

Browse Source 
MessagePack [Key("...")]-keyed contracts reject unknown fields, so request
DTOs that omit BaseRequest's envelope (viewer_id, steam_id,
steam_session_ticket) fail deserialization on the real msgpack wire path.
Routing smoke + JSON-direct tests didn't catch this because S.T.J. tolerates
extra keys and the routing smoke uses ValidBaseRequestJson, but anything
sent via the actual client encrypted=True path threw
MessagePackSerializationException.

Fix: every Arena*Request now inherits BaseRequest. Also updates the JSON
controller tests + e2e to include the envelope so the [ApiController]
auto-400 validation passes.

Discovered via /arena_colosseum/get_fee_info crash on the in-game arena
screen.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
gamer147
2026-05-31 12:06:50 -04:00
parent f8ca4a0ae9
commit 668779e8a4
12 changed files with 37 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
SVSim.EmulatedEntrypoint/Models/Dtos/Requests/ArenaColosseum/GetFeeInfoRequest.cs
View File

@@ -3,4 +3,4 @@ using MessagePack;
namespace SVSim.EmulatedEntrypoint.Models.Dtos.Requests.ArenaColosseum;
[MessagePackObject]
public class GetFeeInfoRequest { }
public class GetFeeInfoRequest : BaseRequest { }

2
SVSim.EmulatedEntrypoint/Models/Dtos/Requests/ArenaTwoPick/BattleFinishRequest.cs
View File

@@ -4,7 +4,7 @@ using MessagePack;
namespace SVSim.EmulatedEntrypoint.Models.Dtos.Requests.ArenaTwoPick;
[MessagePackObject]
public class BattleFinishRequest
public class BattleFinishRequest : BaseRequest
{
[JsonPropertyName("class_id")] [Key("class_id")] public int ClassId { get; set; }
[JsonPropertyName("total_turn")] [Key("total_turn")] public int TotalTurn { get; set; }

2
SVSim.EmulatedEntrypoint/Models/Dtos/Requests/ArenaTwoPick/CardChooseRequest.cs
View File

@@ -4,7 +4,7 @@ using MessagePack;
namespace SVSim.EmulatedEntrypoint.Models.Dtos.Requests.ArenaTwoPick;
[MessagePackObject]
public class CardChooseRequest
public class CardChooseRequest : BaseRequest
{
[JsonPropertyName("selected_id")] [Key("selected_id")] public long SelectedId { get; set; }
}

2
SVSim.EmulatedEntrypoint/Models/Dtos/Requests/ArenaTwoPick/ClassChooseRequest.cs
View File

@@ -4,7 +4,7 @@ using MessagePack;
namespace SVSim.EmulatedEntrypoint.Models.Dtos.Requests.ArenaTwoPick;
[MessagePackObject]
public class ClassChooseRequest
public class ClassChooseRequest : BaseRequest
{
[JsonPropertyName("class_id")] [Key("class_id")] public int ClassId { get; set; }
}

2
SVSim.EmulatedEntrypoint/Models/Dtos/Requests/ArenaTwoPick/DoMatchingRequest.cs
View File

@@ -4,7 +4,7 @@ using MessagePack;
namespace SVSim.EmulatedEntrypoint.Models.Dtos.Requests.ArenaTwoPick;
[MessagePackObject]
public class DoMatchingRequest
public class DoMatchingRequest : BaseRequest
{
[JsonPropertyName("card_master_hash")] [Key("card_master_hash")] public string? CardMasterHash { get; set; }
[JsonPropertyName("deck_no")] [Key("deck_no")] public long DeckNo { get; set; }

2
SVSim.EmulatedEntrypoint/Models/Dtos/Requests/ArenaTwoPick/EntryRequest.cs
View File

@@ -4,7 +4,7 @@ using MessagePack;
namespace SVSim.EmulatedEntrypoint.Models.Dtos.Requests.ArenaTwoPick;
[MessagePackObject]
public class EntryRequest
public class EntryRequest : BaseRequest
{
[JsonPropertyName("consume_item_type")] [Key("consume_item_type")] public int ConsumeItemType { get; set; }
}

2
SVSim.EmulatedEntrypoint/Models/Dtos/Requests/ArenaTwoPick/FinishRequest.cs
View File

@@ -3,4 +3,4 @@ using MessagePack;
namespace SVSim.EmulatedEntrypoint.Models.Dtos.Requests.ArenaTwoPick;
[MessagePackObject]
public class FinishRequest { }
public class FinishRequest : BaseRequest { }

2
SVSim.EmulatedEntrypoint/Models/Dtos/Requests/ArenaTwoPick/RetireRequest.cs
View File

@@ -3,4 +3,4 @@ using MessagePack;
namespace SVSim.EmulatedEntrypoint.Models.Dtos.Requests.ArenaTwoPick;
[MessagePackObject]
public class RetireRequest { }
public class RetireRequest : BaseRequest { }

2
SVSim.EmulatedEntrypoint/Models/Dtos/Requests/ArenaTwoPick/TopRequest.cs
View File

@@ -4,7 +4,7 @@ using MessagePack;
namespace SVSim.EmulatedEntrypoint.Models.Dtos.Requests.ArenaTwoPick;
[MessagePackObject]
public class TopRequest
public class TopRequest : BaseRequest
{
[JsonPropertyName("mode")] [Key("mode")] public int Mode { get; set; }
}