SVSim/SVSimServer
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(gacha-points): look up by odds_gacha_id, not parent_gacha_id

Browse Source 
The two wire fields differ for seasonal packs (verified against
traffic_prod_all_gacha_exchange.ndjson — every captured request pairs
odds_gacha_id=16xxx with parent_gacha_id=10xxx). The OLD DTO docstring
assumed they were always equal; today's controller used
ParentGachaId, which lands on the base/family pack id (often a
synthesized disabled stub with no GachaPointConfig) and returns [].

Fix:
- GetGachaPointRewards and ExchangeGachaPoint now consume OddsGachaId.
- Update both DTO docstrings to document the seasonal-pack pattern.
- Regression test seeds (16015 enabled w/ GachaPointConfig, 10015
  disabled stub w/o config) and asserts the response uses 16015's
  catalog.

Symptom: opening pack 16015 (parent_gacha_id=16015 in /pack/open)
accrued gacha points correctly, but /pack/get_gacha_point_rewards with
{odds_gacha_id:16015, parent_gacha_id:10015} returned an empty list.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
gamer147
2026-05-30 23:30:18 -04:00
parent 9c9d0fc41f
commit 61ae086332
4 changed files with 82 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

61
SVSim.UnitTests/Controllers/PackControllerGachaPointTests.cs
View File

@@ -68,6 +68,67 @@ public class PackControllerGachaPointTests
Assert.That(rewardList[0].GetProperty("reward_number").GetInt32(), Is.EqualTo(1));
}
[Test]
public async Task GetGachaPointRewards_uses_odds_gacha_id_when_it_differs_from_parent_gacha_id()
{
// Regression for the seasonal-pack case captured in traffic_prod_all_gacha_exchange.ndjson:
// the client sends {odds_gacha_id: 16xxx, parent_gacha_id: 10xxx} where odds_gacha_id is
// the active seasonal pack (carries GachaPointConfig + balance) and parent_gacha_id is
// the base/family pack id (often a disabled stub in our DB). Looking up by parent_gacha_id
// would land on the stub and return [].
using var factory = new SVSimTestFactory();
long viewerId = await factory.SeedViewerAsync();
using (var scope = factory.Services.CreateScope())
{
var db = scope.ServiceProvider.GetRequiredService<SVSimDbContext>();
db.Classes.Add(new ClassEntry { Id = 0, Name = "Neutral" });
var set = new ShadowverseCardSetEntry { Id = 16015, IsInRotation = true };
db.CardSets.Add(set);
set.Cards.Add(new ShadowverseCardEntry
{
Id = 115041010, Name = "ucl-leg", Rarity = Rarity.Legendary,
Class = db.Classes.Local.First(), IsFoil = false,
});
db.CardCosmeticRewards.Add(new CardCosmeticReward
{
CardId = 115041010, Type = CosmeticType.Emblem, CosmeticId = 1150410100,
});
// Active seasonal pack — has GachaPointConfig.
db.Packs.Add(new PackConfigEntry
{
Id = 16015, BasePackId = 10015, PackCategory = PackCategory.None,
CommenceDate = DateTime.UtcNow.AddDays(-1), CompleteDate = DateTime.UtcNow.AddDays(30),
GachaType = 1, GachaDetail = "UCL season",
GachaPointConfig = new PackGachaPointConfig { ExchangeablePoint = 400, IncreaseGachaPoint = 1 },
});
// Disabled base/family stub — no GachaPointConfig (matches the synthesized-stub state).
db.Packs.Add(new PackConfigEntry
{
Id = 10015, BasePackId = 10015, PackCategory = PackCategory.None,
CommenceDate = DateTime.UtcNow.AddDays(-1), CompleteDate = DateTime.UtcNow.AddDays(30),
GachaType = 1, GachaDetail = "UCL family stub", IsEnabled = false,
GachaPointConfig = null,
});
await db.SaveChangesAsync();
}
await factory.SeedPackDrawTableFromSetAsync(16015, 16015);
using var client = factory.CreateAuthenticatedClient(viewerId);
// Mirrors the prod capture shape — odds_gacha_id is the active pack, parent_gacha_id
// is the base/family id (here, a disabled stub).
var body = JsonBody("""{"odds_gacha_id":16015,"parent_gacha_id":10015,"viewer_id":"0","steam_id":0,"steam_session_ticket":""}""");
var response = await client.PostAsync("/pack/get_gacha_point_rewards", body);
var text = await response.Content.ReadAsStringAsync();
Assert.That(response.StatusCode, Is.EqualTo(HttpStatusCode.OK), text);
using var doc = JsonDocument.Parse(text);
var rewards = doc.RootElement.GetProperty("gacha_point_rewards");
Assert.That(rewards.GetArrayLength(), Is.EqualTo(1),
"lookup must resolve via odds_gacha_id (16015), not parent_gacha_id (10015)");
Assert.That(rewards[0].GetProperty("card_id").GetInt64(), Is.EqualTo(115041010));
}
[Test]
public async Task GetGachaPointRewards_wire_keys_match_prod_capture()
{