SVSim/SVSimServer
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(gacha-points): look up by odds_gacha_id, not parent_gacha_id

Browse Source 
The two wire fields differ for seasonal packs (verified against
traffic_prod_all_gacha_exchange.ndjson — every captured request pairs
odds_gacha_id=16xxx with parent_gacha_id=10xxx). The OLD DTO docstring
assumed they were always equal; today's controller used
ParentGachaId, which lands on the base/family pack id (often a
synthesized disabled stub with no GachaPointConfig) and returns [].

Fix:
- GetGachaPointRewards and ExchangeGachaPoint now consume OddsGachaId.
- Update both DTO docstrings to document the seasonal-pack pattern.
- Regression test seeds (16015 enabled w/ GachaPointConfig, 10015
  disabled stub w/o config) and asserts the response uses 16015's
  catalog.

Symptom: opening pack 16015 (parent_gacha_id=16015 in /pack/open)
accrued gacha points correctly, but /pack/get_gacha_point_rewards with
{odds_gacha_id:16015, parent_gacha_id:10015} returned an empty list.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
gamer147
2026-05-30 23:30:18 -04:00
parent 9c9d0fc41f
commit 61ae086332
4 changed files with 82 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
SVSim.EmulatedEntrypoint/Models/Dtos/Requests/Pack/ExchangeGachaPointRequest.cs
View File

@@ -4,6 +4,11 @@ using SVSim.EmulatedEntrypoint.Models.Dtos.Requests;
namespace SVSim.EmulatedEntrypoint.Models.Dtos.Requests.Pack;
/// <summary>
/// Inbound /pack/exchange_gacha_point body. See
/// <see cref="GetGachaPointRewardsRequest"/> for the odds_gacha_id vs parent_gacha_id split —
/// same pattern here: the server consumes <c>odds_gacha_id</c> for the lookup.
/// </summary>
[MessagePackObject]
public class ExchangeGachaPointRequest : BaseRequest
{

10
SVSim.EmulatedEntrypoint/Models/Dtos/Requests/Pack/GetGachaPointRewardsRequest.cs
View File

@@ -5,8 +5,14 @@ using SVSim.EmulatedEntrypoint.Models.Dtos.Requests;
namespace SVSim.EmulatedEntrypoint.Models.Dtos.Requests.Pack;
/// <summary>
/// Inbound /pack/get_gacha_point_rewards body. Capture shows odds_gacha_id and parent_gacha_id
/// are always the same value (the pack id); we only consume parent_gacha_id for the lookup.
/// Inbound /pack/get_gacha_point_rewards body.
///
/// The two ids DIFFER for seasonal packs (e.g. UCL):
/// odds_gacha_id = the seasonal "current" pack id (matches /pack/info parent_gacha_id),
/// and is where the GachaPointConfig + gacha-point balance live.
/// parent_gacha_id = the base/family pack id (matches /pack/info base_pack_id).
/// Verified against traffic_prod_all_gacha_exchange.ndjson — every captured request shows
/// the pair as (16xxx, 10xxx). Server consumes <c>odds_gacha_id</c> for the lookup.
/// </summary>
[MessagePackObject]
public class GetGachaPointRewardsRequest : BaseRequest