From 356e58ba250b2113fff1f3dc5616283c6cfc77fe Mon Sep 17 00:00:00 2001 From: gamer147 Date: Sat, 13 Jun 2026 08:12:02 -0400 Subject: [PATCH] feat(degree): /degree/favorite accept-only (persistence deferred) --- .../Controllers/DegreeController.cs | 10 +++++ .../Requests/Degree/DegreeFavoriteRequest.cs | 17 +++++++++ .../DegreeControllerFavoriteTests.cs | 37 +++++++++++++++++++ 3 files changed, 64 insertions(+) create mode 100644 SVSim.EmulatedEntrypoint/Models/Dtos/Requests/Degree/DegreeFavoriteRequest.cs create mode 100644 SVSim.UnitTests/Controllers/DegreeControllerFavoriteTests.cs diff --git a/SVSim.EmulatedEntrypoint/Controllers/DegreeController.cs b/SVSim.EmulatedEntrypoint/Controllers/DegreeController.cs index da37bbf1..3a601f11 100644 --- a/SVSim.EmulatedEntrypoint/Controllers/DegreeController.cs +++ b/SVSim.EmulatedEntrypoint/Controllers/DegreeController.cs @@ -38,4 +38,14 @@ public class DegreeController : SVSimController .ToList(), }; } + + [HttpPost("favorite")] + public ActionResult Favorite([FromBody] DegreeFavoriteRequest _) + { + if (!TryGetViewerId(out long __)) return Unauthorized(); + // Accept-and-ack. Persisting per-viewer cosmetic favorites is deferred until + // a viewer-favorites schema lands (would also serve /sleeve/favorite + /emblem/favorite + // via the shared Wizard/FavoriteTask.cs Kind enum). + return new EmptyResponse(); + } } diff --git a/SVSim.EmulatedEntrypoint/Models/Dtos/Requests/Degree/DegreeFavoriteRequest.cs b/SVSim.EmulatedEntrypoint/Models/Dtos/Requests/Degree/DegreeFavoriteRequest.cs new file mode 100644 index 00000000..99d20b03 --- /dev/null +++ b/SVSim.EmulatedEntrypoint/Models/Dtos/Requests/Degree/DegreeFavoriteRequest.cs @@ -0,0 +1,17 @@ +using MessagePack; +using System.Text.Json.Serialization; + +namespace SVSim.EmulatedEntrypoint.Models.Dtos.Requests.Degree; + +[MessagePackObject] +public class DegreeFavoriteRequest : BaseRequest +{ + // Spec note: ids are STRINGS on the wire, not ints. Same gotcha as /sleeve/favorite and /emblem/favorite. + [JsonPropertyName("favorite_add")] + [Key("favorite_add")] + public List FavoriteAdd { get; set; } = new(); + + [JsonPropertyName("favorite_remove")] + [Key("favorite_remove")] + public List FavoriteRemove { get; set; } = new(); +} diff --git a/SVSim.UnitTests/Controllers/DegreeControllerFavoriteTests.cs b/SVSim.UnitTests/Controllers/DegreeControllerFavoriteTests.cs new file mode 100644 index 00000000..a9211a69 --- /dev/null +++ b/SVSim.UnitTests/Controllers/DegreeControllerFavoriteTests.cs @@ -0,0 +1,37 @@ +using System.Net; +using System.Text; +using NUnit.Framework; +using SVSim.UnitTests.Infrastructure; + +namespace SVSim.UnitTests.Controllers; + +public class DegreeControllerFavoriteTests +{ + [Test] + public async Task Favorite_accepts_add_and_remove_lists() + { + using var factory = new SVSimTestFactory(); + long viewerId = await factory.SeedViewerAsync(tutorialState: 0); + using var client = factory.CreateAuthenticatedClient(viewerId); + + var requestJson = """{"favorite_add":["100","101"],"favorite_remove":["200"],"viewer_id":"0","steam_id":0,"steam_session_ticket":""}"""; + var response = await client.PostAsync("/degree/favorite", + new StringContent(requestJson, Encoding.UTF8, "application/json")); + + Assert.That(response.StatusCode, Is.EqualTo(HttpStatusCode.OK)); + } + + [Test] + public async Task Favorite_accepts_empty_lists() + { + using var factory = new SVSimTestFactory(); + long viewerId = await factory.SeedViewerAsync(tutorialState: 0); + using var client = factory.CreateAuthenticatedClient(viewerId); + + var requestJson = """{"favorite_add":[],"favorite_remove":[],"viewer_id":"0","steam_id":0,"steam_session_ticket":""}"""; + var response = await client.PostAsync("/degree/favorite", + new StringContent(requestJson, Encoding.UTF8, "application/json")); + + Assert.That(response.StatusCode, Is.EqualTo(HttpStatusCode.OK)); + } +}