SVSim/SVSimServer
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

engine cleanup passes 4-7 + multi-instancing ambient rip

Browse Source 
Squashes 146 commits from battle-engine-extraction. Net: 2,045 files changed,
+11,896 / -158,687 lines. Ships engine passes 4-7 (dead-code cull, view-layer
stub, receive-path shrink) plus the Phase-5 AsyncLocal ambient deletion that
turns concurrent battles into a type-system property rather than a scope
contract.

## What landed

**Passes 4-7 (chunks 1-34):** Extended the Phase-4 const-false collapse into a
cascading cull across the skill graph, view layer, and receive-path periphery.
Six mode flags (IsWatchBattle/IsReplayBattle/IsAdmin/IsAdminWatch/IsPuzzleQuest/
IsAINetwork) became `const false`, every guarded block deleted. Field*.cs
subclass ctors + BackGroundBase + ObjectChecker culled to no-ops. Mulligan
family reworked to take a mgr param through IMulliganMgr.InitMulligan.
Emotion/Recovery/Resource clusters null-stubbed. Prediction/OperationSimulator/
skill filters converted from static ambient reads to per-mgr reads via
SkillPrm.ownerCard.SelfBattlePlayer.BattleMgr / ins.BattleMgr / this.BattleMgr.

**Phase-5 ambient rip (chunks 35-47):** Deleted BattleAmbient / BattleAmbient-
Context / TestBattleScope in full. Every per-battle mutable slot now lives on
the mgr instance itself:
  mgr.InstanceIsForecast / InstanceIsRandomDraw / InstanceRecoveryInfo /
  InstanceViewerId / InstanceNetworkAgent / GameMgr
BattleManagerBase.GetIns() returns null unconditionally; the residual static
flags + 3 façades (Certification.ViewerId, Data.BattleRecoveryInfo,
ToolboxGame.RealTimeNetworkAgent) are null-tolerant defaults kept for the
handful of engine-internal readers that still reference their types. Zero
BattleAmbient references anywhere in engine + node + tests.

Added pre-seeded GameMgr ctor overload threaded through the mgr chain
(BattleManagerBase → SingleBattleMgr / NetworkBattleManagerBase → NetworkStandard-
BattleMgr → HeadlessBattleMgr / HeadlessNetworkBattleMgr). Fixtures build a
GameMgr, seed it via HeadlessEngineEnv.SeedCharaIds/SeedNetUser, and pass it
to the mgr's ctor — no ambient reach.

Node side (SVSim.BattleNode/SessionBattleEngine): _ctx replaced with a plain
GameMgr field; 34 `using var _ambient = BattleAmbient.Enter(_ctx)` scope wraps
ripped from every accessor and mutator; EngineGlobalInit.WirePerSessionGameMgr
takes GameMgr as a param and runs from SessionBattleEngine.SetupInternal
BEFORE mgr construction.

Test side: TestBattleScope deleted; 18 fixture [SetUp]s migrated to
`HeadlessEngineEnv.EnsureProcessGlobals()`; MultiInstanceEngineTests rewritten
around per-mgr construction (GetIns() → null is the pinned invariant).

## Regression fixes

- **chunk-48** (MulliganCtrl): chunk-35's `= null` stubs on card lookups broke
  the live receive-driven Deal path (BattlePlayerBase.DrawCard NRE'd downstream
  of NetworkPlayerMulliganCtrl.StartMulliganVfx). Restored the three lookups
  via `_battlePlayer.BattleMgr.GetBattleCardIdx`. Engine tests were satisfied
  by the WireMulliganPhase seam; unit tests exposed the live-path gap.

## Ship state

- SVSim.BattleEngine.Tests: 56/56 pass, 2 skip
- SVSim.UnitTests: 1554/1554 pass (was 1523/31-fail before chunk 48)
- Solution build: 0 source warnings (40 pre-existing NU1902 MessagePack CVEs
  in SVSim.EmulatedEntrypoint, unrelated)
- Sequential PVP smoke: verified live (two back-to-back battles, no regression
  on cleanup/spinup)
- Concurrent PVP smoke: verified live

Adds tools/engine-port/ClosureAnalyzer/ — the Roslyn transitive-type-closure
analyzer needed to make future cascade cleanup safe (per feedback memory
"Engine cleanup needs closure tool" from the 2026-06-28 pass-3 failure).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
gamer147
2026-07-03 19:18:54 -04:00
parent 5c1db83967
commit 2d9a6eea4b
2045 changed files with 11704 additions and 158495 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
SVSim.BattleEngine/Engine/Wizard.Battle.Phase/NetworkMulliganPhase.cs
View File

@@ -3,6 +3,10 @@ using System.Collections.Generic;
using Cute;
using Wizard.Battle.Mulligan;
using Wizard.Battle.View.Vfx;
// TODO(engine-cleanup-pass2): 6 of 11 methods unrun in baseline
// Type: Wizard.Battle.Phase.NetworkMulliganPhase
// See data_dumps/reports/engine-cleanup/live-methods.baseline.txt
namespace Wizard.Battle.Phase;
@@ -22,7 +26,7 @@ public class NetworkMulliganPhase : MulliganPhaseBase
: base(battleMgr)
{
_networkBattleMgr = battleMgr;
if (GameMgr.GetIns().IsAINetwork)
if (_networkBattleMgr.GameMgr.IsAINetwork)
{
_singleMulliganMgr = new SingleMulliganMgr();
}
@@ -31,7 +35,7 @@ public class NetworkMulliganPhase : MulliganPhaseBase
_networkMulliganMgr = new NetworkMulliganMgr(sender);
}
IMulliganMgr mulliganMgr;
if (!GameMgr.GetIns().IsAINetwork)
if (!_networkBattleMgr.GameMgr.IsAINetwork)
{
IMulliganMgr networkMulliganMgr = _networkMulliganMgr;
mulliganMgr = networkMulliganMgr;
@@ -60,12 +64,12 @@ public class NetworkMulliganPhase : MulliganPhaseBase
IMulliganMgr mulliganMgr = _mulliganMgr;
mulliganMgr.OnSubmit = (Action)Delegate.Combine(mulliganMgr.OnSubmit, (Action)delegate
{
if (GameMgr.GetIns().IsAINetwork)
if (_networkBattleMgr.GameMgr.IsAINetwork)
{
SingleMulliganMgr singleMulligan = _mulliganMgr as SingleMulliganMgr;
OnNetworkAlive = (Action)Delegate.Combine(OnNetworkAlive, (Action)delegate
{
singleMulligan.AIMulliganEndAction();
singleMulligan.AIMulliganEndAction(_networkBattleMgr);
OnNetworkAlive = null;
});
}
@@ -74,7 +78,7 @@ public class NetworkMulliganPhase : MulliganPhaseBase
public override VfxWith<IPhase> Update(float dt)
{
if (GameMgr.GetIns().IsAINetwork && ToolboxGame.RealTimeNetworkAgent != null && ToolboxGame.RealTimeNetworkAgent.PlayerNetworkStatus.IsAlive)
if (_networkBattleMgr.GameMgr.IsAINetwork && _networkBattleMgr.InstanceNetworkAgent != null && _networkBattleMgr.InstanceNetworkAgent.PlayerNetworkStatus.IsAlive)
{
OnNetworkAlive.Call();
}
@@ -83,7 +87,7 @@ public class NetworkMulliganPhase : MulliganPhaseBase
public void MulliganEventSetting()
{
if (!GameMgr.GetIns().IsAINetwork)
if (!_networkBattleMgr.GameMgr.IsAINetwork)
{
OperateReceive operateReceive = _networkBattleMgr.OperateReceive;
operateReceive.OnEndMulligan = (Func<VfxBase>)Delegate.Combine(operateReceive.OnEndMulligan, new Func<VfxBase>(EndMulligan));
@@ -99,7 +103,7 @@ public class NetworkMulliganPhase : MulliganPhaseBase
public override VfxBase Teardown()
{
VfxBase result = base.Teardown();
if (GameMgr.GetIns().IsAINetwork)
if (_networkBattleMgr.GameMgr.IsAINetwork)
{
return result;
}
@@ -119,13 +123,13 @@ public class NetworkMulliganPhase : MulliganPhaseBase
LocalLog.AccumulateLastTraceLog("EndMulligan");
SequentialVfxPlayer sequentialVfxPlayer = SequentialVfxPlayer.Create();
sequentialVfxPlayer.Register(this.OnEndMulligan.GetAllFuncVfxResults());
sequentialVfxPlayer.Register(GameMgr.GetIns().IsAINetwork ? _singleMulliganMgr.CompleteMulligan(_networkBattleMgr) : _networkMulliganMgr.CompleteMulligan(_networkBattleMgr));
sequentialVfxPlayer.Register(_networkBattleMgr.GameMgr.IsAINetwork ? _singleMulliganMgr.CompleteMulligan(_networkBattleMgr) : _networkMulliganMgr.CompleteMulligan(_networkBattleMgr));
return sequentialVfxPlayer;
}
protected virtual VfxBase ReceivePlayerMulligan(List<int> mulliganAfterCardIndexes)
{
if (GameMgr.GetIns().IsAINetwork)
if (_networkBattleMgr.GameMgr.IsAINetwork)
{
return NullVfx.GetInstance();
}
@@ -136,7 +140,7 @@ public class NetworkMulliganPhase : MulliganPhaseBase
protected VfxBase ReceiveOpponentMulligan(List<int> mulliganAfterCardIndexes)
{
LocalLog.AccumulateLastTraceLog("ReceiveOpponentMulligan");
if (GameMgr.GetIns().IsAINetwork)
if (_networkBattleMgr.GameMgr.IsAINetwork)
{
return NullVfx.GetInstance();
}