feat(guild): invite state machine
Add surrogate PK (IDENTITY bigint) to GuildInvite for wire invite_id. Implement InviteAsync, CancelInviteAsync, RejectInviteAsync, ListOutgoingInvitesAsync, ListInvitedGuildsAsync in GuildService. Wire 5 endpoints: invite_user_list, invited_guild_list, invite, cancel_invite, reject_invite in GuildController. Migration: AddGuildInviteSurrogatePk — drops composite PK, adds Id IDENTITY column, adds unique index on (GuildId, InviteeViewerId). 6 integration tests in GuildInviteFlowTests all green. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
gamer147
@@ -190,14 +190,65 @@ public sealed class GuildService : IGuildService
|
||||
return GuildOpResult.Ok;
|
||||
}
|
||||
|
||||
public Task<GuildOpResult> InviteAsync(long callerViewerId, long targetViewerId, CancellationToken ct = default)
|
||||
=> throw new NotImplementedException();
|
||||
public async Task<GuildOpResult> InviteAsync(long callerViewerId, long targetViewerId, CancellationToken ct = default)
|
||||
{
|
||||
// Caller must be a guild member with Leader or SubLeader role.
|
||||
var callerMembership = await _members.GetMembershipAsync(callerViewerId, ct);
|
||||
if (callerMembership is null) return new(GuildOpResultCode.NotInGuild);
|
||||
if (callerMembership.Role is not (GuildRole.Leader or GuildRole.SubLeader))
|
||||
return new(GuildOpResultCode.PermissionDenied);
|
||||
|
||||
public Task<GuildOpResult> CancelInviteAsync(long callerViewerId, long targetViewerId, CancellationToken ct = default)
|
||||
=> throw new NotImplementedException();
|
||||
// Target must not already be in any guild.
|
||||
var targetMembership = await _members.GetMembershipAsync(targetViewerId, ct);
|
||||
if (targetMembership is not null) return new(GuildOpResultCode.AlreadyInGuild);
|
||||
|
||||
public Task<GuildOpResult> RejectInviteAsync(long callerViewerId, int guildId, CancellationToken ct = default)
|
||||
=> throw new NotImplementedException();
|
||||
// No duplicate pending invite to the same target from the same guild.
|
||||
var existing = await _invites.GetAsync(callerMembership.GuildId, targetViewerId, ct);
|
||||
if (existing is { Status: GuildInviteStatus.Pending }) return new(GuildOpResultCode.InviteAlreadyResolved);
|
||||
|
||||
var now = DateTime.UtcNow;
|
||||
await _invites.AddAsync(new GuildInvite
|
||||
{
|
||||
GuildId = callerMembership.GuildId,
|
||||
InviteeViewerId = targetViewerId,
|
||||
InviterViewerId = callerViewerId,
|
||||
Status = GuildInviteStatus.Pending,
|
||||
CreatedAt = now,
|
||||
}, ct);
|
||||
|
||||
return GuildOpResult.Ok;
|
||||
}
|
||||
|
||||
public async Task<GuildOpResult> CancelInviteAsync(long callerViewerId, long inviteId, CancellationToken ct = default)
|
||||
{
|
||||
// Caller must be in their guild with Leader or SubLeader role.
|
||||
var callerMembership = await _members.GetMembershipAsync(callerViewerId, ct);
|
||||
if (callerMembership is null) return new(GuildOpResultCode.NotInGuild);
|
||||
if (callerMembership.Role is not (GuildRole.Leader or GuildRole.SubLeader))
|
||||
return new(GuildOpResultCode.PermissionDenied);
|
||||
|
||||
var invite = await _invites.GetByIdAsync(inviteId, ct);
|
||||
if (invite is null) return new(GuildOpResultCode.InviteNotFound);
|
||||
// Caller must belong to the same guild as the invite.
|
||||
if (invite.GuildId != callerMembership.GuildId) return new(GuildOpResultCode.PermissionDenied);
|
||||
if (invite.Status != GuildInviteStatus.Pending) return new(GuildOpResultCode.InviteAlreadyResolved);
|
||||
|
||||
await _invites.UpdateStatusAsync(invite.GuildId, invite.InviteeViewerId, GuildInviteStatus.Canceled, DateTime.UtcNow, ct);
|
||||
return GuildOpResult.Ok;
|
||||
}
|
||||
|
||||
public async Task<GuildOpResult> RejectInviteAsync(long callerViewerId, long inviteId, CancellationToken ct = default)
|
||||
{
|
||||
// Invitee rejects — no guild membership check needed.
|
||||
var invite = await _invites.GetByIdAsync(inviteId, ct);
|
||||
if (invite is null) return new(GuildOpResultCode.InviteNotFound);
|
||||
// Caller must be the invitee.
|
||||
if (invite.InviteeViewerId != callerViewerId) return new(GuildOpResultCode.PermissionDenied);
|
||||
if (invite.Status != GuildInviteStatus.Pending) return new(GuildOpResultCode.InviteAlreadyResolved);
|
||||
|
||||
await _invites.UpdateStatusAsync(invite.GuildId, callerViewerId, GuildInviteStatus.Rejected, DateTime.UtcNow, ct);
|
||||
return GuildOpResult.Ok;
|
||||
}
|
||||
|
||||
public Task<GuildOpResult> JoinAsync(long viewerId, int guildId, CancellationToken ct = default)
|
||||
=> throw new NotImplementedException();
|
||||
@@ -221,7 +272,61 @@ public sealed class GuildService : IGuildService
|
||||
=> throw new NotImplementedException();
|
||||
|
||||
public Task<IReadOnlyList<Entities.Guild.GuildInvite>> ListPendingInvitesForMeAsync(long viewerId, CancellationToken ct = default)
|
||||
=> throw new NotImplementedException();
|
||||
=> _invites.ListPendingForInviteeAsync(viewerId, ct);
|
||||
|
||||
public async Task<IReadOnlyList<GuildOutgoingInviteEntry>> ListOutgoingInvitesAsync(long callerViewerId, CancellationToken ct = default)
|
||||
{
|
||||
var membership = await _members.GetMembershipAsync(callerViewerId, ct);
|
||||
if (membership is null) return Array.Empty<GuildOutgoingInviteEntry>();
|
||||
|
||||
var pendingInvites = await _invites.ListPendingForGuildAsync(membership.GuildId, ct);
|
||||
if (pendingInvites.Count == 0) return Array.Empty<GuildOutgoingInviteEntry>();
|
||||
|
||||
var inviteeIds = pendingInvites.Select(i => i.InviteeViewerId).Distinct().ToList();
|
||||
var names = await _viewers.LoadDisplayNamesAsync(inviteeIds, ct);
|
||||
|
||||
// Load emblem + degree data for invitees.
|
||||
var viewerRows = await _db.Viewers
|
||||
.AsNoTracking()
|
||||
.Include(v => v.Info.SelectedEmblem)
|
||||
.Include(v => v.Info.SelectedDegree)
|
||||
.Where(v => inviteeIds.Contains(v.Id))
|
||||
.ToDictionaryAsync(v => v.Id, ct);
|
||||
|
||||
var result = new List<GuildOutgoingInviteEntry>(pendingInvites.Count);
|
||||
foreach (var invite in pendingInvites)
|
||||
{
|
||||
viewerRows.TryGetValue(invite.InviteeViewerId, out var v);
|
||||
result.Add(new GuildOutgoingInviteEntry(
|
||||
InviteId: invite.Id,
|
||||
InviteeViewerId: invite.InviteeViewerId,
|
||||
Name: names.GetValueOrDefault(invite.InviteeViewerId, ""),
|
||||
EmblemId: v?.Info?.SelectedEmblem?.Id is > 0 ? v.Info.SelectedEmblem.Id : 100_000_000L,
|
||||
CountryCode: v?.Info?.CountryCode ?? "",
|
||||
Rank: 1,
|
||||
DegreeId: v?.Info?.SelectedDegree?.Id ?? 0,
|
||||
CreatedAt: invite.CreatedAt));
|
||||
}
|
||||
return result;
|
||||
}
|
||||
|
||||
public async Task<IReadOnlyList<GuildReceivedInviteEntry>> ListInvitedGuildsAsync(long viewerId, CancellationToken ct = default)
|
||||
{
|
||||
// ListPendingForInviteeAsync already includes the Guild nav prop.
|
||||
var pendingInvites = await _invites.ListPendingForInviteeAsync(viewerId, ct);
|
||||
if (pendingInvites.Count == 0) return Array.Empty<GuildReceivedInviteEntry>();
|
||||
|
||||
var guildIds = pendingInvites.Select(i => i.GuildId).Distinct().ToList();
|
||||
var memberCounts = await _members.CountBatchByGuildIdsAsync(guildIds, ct);
|
||||
var leaderIds = pendingInvites.Select(i => i.Guild.LeaderViewerId).Distinct().ToList();
|
||||
var leaderNames = await _viewers.LoadDisplayNamesAsync(leaderIds, ct);
|
||||
|
||||
return pendingInvites.Select(invite => new GuildReceivedInviteEntry(
|
||||
InviteId: invite.Id,
|
||||
Guild: invite.Guild,
|
||||
MemberNum: memberCounts.GetValueOrDefault(invite.GuildId, 0),
|
||||
LeaderName: leaderNames.GetValueOrDefault(invite.Guild.LeaderViewerId, ""))).ToList();
|
||||
}
|
||||
|
||||
public Task<IReadOnlyList<Entities.Guild.GuildJoinRequest>> ListPendingJoinRequestsForMyGuildAsync(long viewerId, CancellationToken ct = default)
|
||||
=> throw new NotImplementedException();
|
||||
|
||||
Reference in New Issue
Block a user