SVSim/SVSimServer
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

port(m1): wave 7k — M1 COMPLETE: 0 compile errors, headless engine builds (12->0)

Browse Source 
Final three clusters:
- RoomParamKey: copy Wizard.RoomMatch/RoomParamKey.cs verbatim (UriNames/WatchUriNames
  static dicts keyed by PlayerController.ROOM_URI + PlayerControllerForWatching.
  SEND_PARAMETER — both now real enums).
- CardChooseTask: copy the TwoPick/CardChooseTask.cs (TaskManager `using`s .Arena.TwoPick,
  not .Competition — copy_loop had only landed the Competition twin).
- SetCardNumLabel CS1739: decompiler param-name artifact — the local fn's 3rd param was
  recovered as `flag` but call sites pass it named `isRed:`. First DP5 tracked patch:
  Engine/UICardList.cs edited (flag->isRed, zero logic change), recorded in
  Patches/ + manifest patched=1 (drift-clean).

M1 exit criteria met: `dotnet build SVSim.BattleEngine` = 0 errors, no Unity ref in csproj,
check_drift clean. Session 7: 198 -> 0 across waves 7a-7k.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
gamer147
2026-06-06 01:03:58 -04:00
parent f63d1cc2e2
commit 1078b1ef50
6 changed files with 302 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
SVSim.BattleEngine/Patches/UICardList.SetCardNumLabel-param-rename.patch Normal file
View File

@@ -0,0 +1,15 @@
Decompiler artifact: the local function `SetCardNumLabel(UILabel, int, bool)` had its
third parameter recovered as `flag`, but the (also-decompiled) call sites pass it by the
named argument `isRed:` (lines 875-876). Param name vs. named-arg mismatch -> CS1739.
Mechanical fix (zero logic change): rename the parameter `flag` -> `isRed` and its single
use in the body. No behavior change.
--- Engine/UICardList.cs (local fn ~line 878)
- static void SetCardNumLabel(UILabel label, int num3, bool flag)
+ static void SetCardNumLabel(UILabel label, int num3, bool isRed)
{
label.text = num3.ToString();
- label.color = (flag ? LabelDefine.TEXT_COLOR_RED : LabelDefine.TEXT_COLOR_NORMAL);
+ label.color = (isRed ? LabelDefine.TEXT_COLOR_RED : LabelDefine.TEXT_COLOR_NORMAL);
}